Conversation
jwils
added this pull request to stack #1390
September 14, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Disk-backed artifacts and in-memory schema results expose different JSON APIs. Adding each ingestion format's methods to core would require changes there for every third-party format.
What
Add an extension-owned artifact registry shared by disk and in-memory results. JSON and protobuf provide their own artifact APIs through this registry.
How
Extensions register a name, factory, require path, and configuration during schema definition. Runtime metadata preserves that registration. Each factory supplies disk and in-memory providers with the same extension-specific interface.
schema_artifacts.extension_artifacts.fetch(name)loads and caches only the requested provider. Core defines no JSON or protobuf artifact methods. A custom-provider test exercises registration, artifact generation, disk loading, configuration, and coexistence with another format. Other tests cover absent providers, duplicate registration, lazy loading, and instance isolation.Risk
Callers of JSON methods on
FromDiskorResultsmust useextension_artifacts.fetch("json")first. Existing artifacts must be regenerated to include provider registrations. Applications need the provider gems they access; unrelated providers remain unloaded.Testing
No manual testing. Local datastore tests remain blocked by Docker Desktop's required organization sign-in.
Bigger picture
Stacked on #1384. Third-party gems can now expose custom artifact APIs without adding format-specific methods or dependencies to core.