Split the proto_ingestion schema spec into cohesive files - #1379
Merged
Merged
Conversation
jwils
added this pull request to stack #1381
September 11, 2026 20:58
jwils
changed the title
jwils
marked this pull request as ready for review
September 11, 2026 20:59
jwils
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
September 11, 2026 20:59
jwils
removed this pull request from stack #1381
September 13, 2026 15:10
jwils
force-pushed
the
joshuaw/proto-spec-organization
branch
from
September 13, 2026 15:13
78dedef to
6dd2a4c
Compare
jwils
force-pushed
the
joshuaw/proto-spec-organization
branch
from
September 13, 2026 15:24
6dd2a4c to
59a8cff
Compare
myronmarston
approved these changes
Sep 13, 2026
myronmarston
left a comment
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I did notice that your commit message mentioned external_proto_enums_spec.rb which does not exist--does that point to something that wasn't included in this PR that was intended to be?
`schema_spec.rb` still held 34 examples covering every proto schema generation concern, and "schema" is a broad enough label that it would keep growing. Move each cohesive group out of it: - `scalar_proto_types_spec.rb` (added by #1306) gains the 4 remaining scalar examples, so every scalar proto type example now lives together - `proto_field_number_mappings_spec.rb` covers field and enum value numbers staying stable as the schema evolves - `abstract_types_spec.rb` covers `oneof` wrappers for interface and union types - `proto_syntax_and_headers_spec.rb` covers the `syntax:` and `header_lines:` options `schema_spec.rb` keeps the 6 examples that cover schema generation as a whole. Every example moved verbatim, so this changes no behavior and adds no coverage. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jwils
force-pushed
the
joshuaw/proto-spec-organization
branch
from
September 13, 2026 17:12
59a8cff to
589beee
Compare
jwils
enabled auto-merge (squash)
September 13, 2026 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
elasticgraph-proto_ingestion'sschema_spec.rbstill held 24 examples covering every proto schema generation concern, and "schema" is a broad enough label that it would keep growing. Per review feedback on #1306, the remaining scalar examples belong inscalar_proto_types_spec.rb, and the other cohesive groups deserve their own files too.What
Move each cohesive group of examples out of
schema_spec.rb:scalar_proto_types_spec.rb(added by #1306)import:andfield_comment:proto_field_number_mappings_spec.rbabstract_types_spec.rboneofwrappers for interface and union typesproto_syntax_and_headers_spec.rbsyntax:andheader_lines:optionsschema_spec.rbkeeps the 6 examples that cover schema generation as a whole, dropping from 727 lines to 172.Every moved example body remains byte-identical.
schema_edge_cases_spec.rbis untouched.Risk Assessment
None — spec file organization only. No behavior change, no coverage change (
elasticgraph-proto_ingestionstays at 100% line and branch coverage).References