fix(desktop): render goose's system prompt in the activity log - #4182
Open
sumit-m wants to merge 1 commit into
Open
fix(desktop): render goose's system prompt in the activity log#4182sumit-m wants to merge 1 commit into
sumit-m wants to merge 1 commit into
Conversation
Goose delivers standing context through a separate request after session/new, so it produced no System prompt card at all. All three delivery routes now render the same card in the same place. Signed-off-by: sumit-m <33051892+sumit-m@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Goose agents never show a System prompt card in the agent activity log. Every other runtime does.
The transcript builder turns a
session/newrequest into that card by readingparams.systemPrompt. Goose does not receive its system prompt that way —buzz-acpsends it as a separate request immediately aftersession/new:agentSessionTranscript.tshas no branch for that method, so the request is observed but never rendered. The result is that a goose agent's base prompt, persona, team instructions, core memory and canvas are invisible in the UI — there is no way to see what the agent was actually told.Fix
Read
params.textfrom that request and upsert the same"System prompt"metadata item thesession/newpath already produces.The request lands before the session's first turn, so reusing the existing
acpSource: "session/new"places the card in the same standalone slot at the head of the session run — no changes to grouping or presentation.Notes
else ifbranch. No existing path changes, and nothing renders differently for runtimes that already worked.goose_system_prompt_supported == Some(false)). That path is untouched —[Base]continues to appear in Prompt context as before.goose_system_prompt_request_uses_append_contractassertsmethod,mode,keyandtexton the bytes written), andwrite_ndjsonobserves every outbound message, so the frame this branch consumes is guaranteed to be emitted.Test
One new test asserting a goose system-prompt request produces exactly one card, with the same
["Base", "System"]sections, outside any turn bucket.pnpm test3886 passing,pnpm typecheckclean,biome checkclean.Not verified against a live goose agent — I have no goose model configured. The chain is covered by tests on both sides of the wire.