buzz-acp: add structured MCP server configuration - #4164
Conversation
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9e32d5848
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: KC <79471844+wolfyy970@users.noreply.github.com>
|
I opened #4301 to capture the broader Agent Capsule product shape and the proposed PR sequence. This PR remains the first narrow slice: structured, named MCP configuration in |
Summary
Adds a versioned JSON config for defining multiple named MCP servers in
buzz-acp.The new
--mcp-configandBUZZ_ACP_MCP_CONFIGinputs preserve each server's name, command, arguments, order, and environment without shell parsing. Invalid configuration fails before startup. The existingBUZZ_ACP_MCP_COMMANDpath is unchanged and remains first when both inputs are present.MCP environment values are redacted from Buzz wire logs and observer events. Serialized request payloads echoed by an adapter in errors or diagnostics are suppressed without changing the protocol value.
Desktop also reserves
BUZZ_ACP_MCP_CONFIGbecause it points to a code-execution surface.Fixes #4154.
Notes
Structured MCP servers receive only their declared environment in the ACP request. This is not process isolation: the adapter still inherits the harness environment and controls its MCP child processes.
The diagnostic redaction overlaps #3417.
Validation
cargo test -p buzz-acp --no-fail-fast(686 unit tests, 10 integration tests)cargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt --all -- --check./bin/just ci