Bump default pbkdf2 iterations - #4212
Merged
Merged
Conversation
kajoseph
added
the
BWC
MichaelAJay
approved these changes
Aug 6, 2026
nitsujlangston
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current pbkdf2 iterations are lower than the OWASP recommended number. This can be overridden anyway but better to have a sensible number as default. Ideally, we'd migrate to something like Argon2id, but this is better than nothing in the meantime.
Changelog
PBKDF2_ITERATIONSto OWASP recommended 600,000 iterations for SHA-256.Testing Notes
All tests should pass. No breaking changes here. All previously encrypted payloads should work as before.
Checklist