Ecies tweaks - #4211
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the bitcore-tss ECIES implementation to reduce “smell” during the migration to a new encryption scheme, while also tightening linting/formatting and updating related build/test configuration.
Changes:
- Refactors ECIES key derivation and authentication (HKDF-based KDF, MAC includes IV), removes
shortTagsupport, and updates ECIES test vectors accordingly. - Adds lint/fix scripts and enables ESLint rules for
packages/bitcore-tss/**/*.js; applies formatting/lint cleanups across test/config files. - Updates
@bitgo/sdk-lib-mpcdependency (and lockfile), plus small webpack/wdio config adjustments.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bitcore-tss/webpack.config.js | Minor cleanup in module replacement regex and require ordering. |
| packages/bitcore-tss/wdio.conf.js | Formatting/indentation normalization; no intended runtime behavior change. |
| packages/bitcore-tss/test/ecies.test.js | Updates ECIES vectors and removes shortTag test coverage. |
| packages/bitcore-tss/test/ecdsa.test.js | Minor lint fixes (missing semicolons / object literal). |
| packages/bitcore-tss/test/data/vectors.ecdsa.js | String/style normalization in test vectors. |
| packages/bitcore-tss/package.json | Adds lint/fix scripts and bumps @bitgo/sdk-lib-mpc. |
| packages/bitcore-tss/package-lock.json | Lockfile updates for the bumped dependency and new transitive deps. |
| packages/bitcore-tss/index.js | Semicolon/style fix. |
| packages/bitcore-tss/ecies/ecies.js | Core ECIES refactor: HKDF KDF, MAC changes, removes shortTag option handling, timing-safe compare. |
| packages/bitcore-tss/ecdsa/sign.js | Require ordering tweak. |
| packages/bitcore-tss/ecdsa/keygen.js | Require ordering tweak. |
| eslint.config.mjs | Adds bitcore-tss to CommonJS ESLint config scope. |
Files not reviewed (1)
- packages/bitcore-tss/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MichaelAJay
reviewed
Aug 5, 2026
MichaelAJay
approved these changes
Aug 6, 2026
nitsujlangston
previously approved these changes
Aug 6, 2026
nitsujlangston
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up ECIES implementation so it's not so smelly while we migrate to a better encryption scheme
Changelog
Testing Notes
All tests should pass as normal
Checklist