Skip to content

Ecies tweaks - #4211

Merged
kajoseph merged 11 commits into
bitpay:masterfrom
kajoseph:eciesTweaks
Aug 6, 2026
Merged

Ecies tweaks#4211
kajoseph merged 11 commits into
bitpay:masterfrom
kajoseph:eciesTweaks

Conversation

@kajoseph

@kajoseph kajoseph commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Cleans up ECIES implementation so it's not so smelly while we migrate to a better encryption scheme

Changelog

  • Fixes some basic issues
  • Lints
  • Remove shortTag

Testing Notes

All tests should pass as normal


Checklist

  • I have read CONTRIBUTING.md and verified that this PR follows the guidelines and requirements outlined in it.

@kajoseph
kajoseph requested a review from Copilot August 3, 2026 22:28
@kajoseph kajoseph added the bitcore-tss This pull request modifies the bitcore-tss package label Aug 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the bitcore-tss ECIES implementation to reduce “smell” during the migration to a new encryption scheme, while also tightening linting/formatting and updating related build/test configuration.

Changes:

  • Refactors ECIES key derivation and authentication (HKDF-based KDF, MAC includes IV), removes shortTag support, and updates ECIES test vectors accordingly.
  • Adds lint/fix scripts and enables ESLint rules for packages/bitcore-tss/**/*.js; applies formatting/lint cleanups across test/config files.
  • Updates @bitgo/sdk-lib-mpc dependency (and lockfile), plus small webpack/wdio config adjustments.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/bitcore-tss/webpack.config.js Minor cleanup in module replacement regex and require ordering.
packages/bitcore-tss/wdio.conf.js Formatting/indentation normalization; no intended runtime behavior change.
packages/bitcore-tss/test/ecies.test.js Updates ECIES vectors and removes shortTag test coverage.
packages/bitcore-tss/test/ecdsa.test.js Minor lint fixes (missing semicolons / object literal).
packages/bitcore-tss/test/data/vectors.ecdsa.js String/style normalization in test vectors.
packages/bitcore-tss/package.json Adds lint/fix scripts and bumps @bitgo/sdk-lib-mpc.
packages/bitcore-tss/package-lock.json Lockfile updates for the bumped dependency and new transitive deps.
packages/bitcore-tss/index.js Semicolon/style fix.
packages/bitcore-tss/ecies/ecies.js Core ECIES refactor: HKDF KDF, MAC changes, removes shortTag option handling, timing-safe compare.
packages/bitcore-tss/ecdsa/sign.js Require ordering tweak.
packages/bitcore-tss/ecdsa/keygen.js Require ordering tweak.
eslint.config.mjs Adds bitcore-tss to CommonJS ESLint config scope.
Files not reviewed (1)
  • packages/bitcore-tss/package-lock.json: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/bitcore-tss/ecies/ecies.js
Comment thread packages/bitcore-tss/ecies/ecies.js Outdated
Comment thread packages/bitcore-tss/ecies/ecies.js
Comment thread packages/bitcore-tss/ecies/ecies.js
nitsujlangston
nitsujlangston previously approved these changes Aug 6, 2026
@kajoseph
kajoseph merged commit 6caf8cc into bitpay:master Aug 6, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bitcore-tss This pull request modifies the bitcore-tss package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants