Skip to content

News346: correct waitNext() fee_threshold / MAX_MONEY description - #2823

Open
Bartok9 wants to merge 1 commit into
bitcoinops:masterfrom
Bartok9:fix/news346-waitnext-max-money
Open

News346: correct waitNext() fee_threshold / MAX_MONEY description#2823
Bartok9 wants to merge 1 commit into
bitcoinops:masterfrom
Bartok9:fix/news346-waitnext-max-money

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

News #346 said waitNext() returns when mempool fees rise "above MAX_MONEY". That is wrong: fee_threshold defaults to MAX_MONEY and that default skips the fee check so the wait is tip-change (or timeout) only. Callers who want fee-triggered updates set a lower threshold.

Closes #2591.

English only; translations of #346 can follow.


Agent-Owner: sera · Platform: hermes · Claim-TTL: 24h

MAX_MONEY is the default fee_threshold that disables fee-based template
updates, not a threshold that mempool fees must exceed.
@stickies-v

Copy link
Copy Markdown
Collaborator

@bitschmidty what's the policy on AI contributions? would rather use my own AI than talk to someone else's. can I close this?

@Bartok9

Bartok9 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Hi @stickies-v — happy to clarify, and no worries at all if you'd rather carry it yourself. This edit is AI-assisted but human-reviewed; the underlying catch (the waitNext() fee_threshold / MAX_MONEY description) is a small factual correction to the news summary. Totally fine by me if you'd prefer to fold it into your own workflow and close this — the goal is just getting the description right. Whatever's least friction for you.

@bitschmidty

Copy link
Copy Markdown
Contributor

@bitschmidty what's the policy on AI contributions? would rather use my own AI than talk to someone else's. can I close this?

I dont think Optech has any such policy at the moment. I personally find these AI PRs harder to parse and review due to the verbosity.

Tagging @Gustavojfe as well since he was the original author of this specific item.

@Bartok9

Bartok9 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Understood, and point taken on verbosity — I'll keep it terse. In short: the item said waitNext() returns when fees drop below a threshold, but it actually returns when the total available fees reach fee_threshold (defaulting to MAX_MONEY), so the one-liner fix corrects that direction. Happy to defer to @Gustavojfe as original author — fold it in or close, whatever's least friction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

News346: incorrect waitNext() description

3 participants