Feature/officialfrancismendoza/49 no std default#54
Draft
officialfrancismendoza wants to merge 42 commits into
Draft
Feature/officialfrancismendoza/49 no std default#54officialfrancismendoza wants to merge 42 commits into
officialfrancismendoza wants to merge 42 commits into
Conversation
- 출력 슬라이스를 받는 _out 계열 함수 진입부에서 out fill(0) 선-초기화 - 오버사이즈 버퍼 뒤쪽이나 조기 반환 시 남는 이전 데이터 노출 방지 - digest 출력 버퍼 뒤쪽까지 0이 되도록 sha3 테스트 1건 갱신 - 행 단위 부분 기록 함수는 다른 행을 지우므로 제외
…ers' into release/0.1.2alpha. Closes bcgit#18
…ers' into release/0.1.2alpha. Closes bcgit#18
…o release/0.1.2alpha. Closes bcgit#15
* removed nightly feature from mldsa * Split the Signature trait into Signer and SignatureVerifier * Split the KEM trait into KEMEncapsulator and KEMDecapsulator * Touched up some documentation
…ory defaults Replace the three pub DEFAULT_*_HASH_NAME constants with direct enum variant construction in Default, default_128_bit(), and default_256_bit(). The constants were only used internally to drive Self::new().unwrap() calls — removing them makes the defaults infallible at compile time and reduces the public surface area of the factory. Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
…y defaults Same pattern as the HashFactory cleanup: replace the three pub DEFAULT_*_KDF_NAME constants with direct enum variant construction in Default, default_128_bit(), and default_256_bit(). The constants were only used internally to drive unwrap() calls on Self::new() — removing them makes the defaults infallible at compile time and shrinks the public API surface. Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
…y defaults Replace pub DEFAULT_KDF_NAME, DEFAULT_128BIT_KDF_NAME, and DEFAULT_256BIT_KDF_NAME with direct enum variant construction in Default, default_128_bit(), and default_256_bit(). The constants existed solely to feed Self::new().unwrap() — constructing the variants directly makes the defaults infallible at compile time and removes three unnecessary items from the public API. Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
Replace manual length checks followed by unwrap() with try_into().map_err() to coerce the signature slice to a fixed-size array in one step. Replace assert!() + unwrap() on the streaming verifier's optional public key with ok_or(), returning a proper SignatureError::GenericError instead of panicking. Use .then_some().ok_or() to convert the boolean verify result into a Result without an if/else branch. Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
…st into merge-pr-43
…r the impl for SHA2 and SHA3.
…m the same patch stream
…d everything from u8 to using const array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft pull request on handling (#49), but rebased off changes from (#48) at least part of the way through. Main missing items are to backfill features to allow an "std" option that keeps the original while also retaining the optimized under feature named "alloc" (which is basically our no_std default).