Support Dokka v2 - #75
Merged
Merged
Conversation
# Conflicts: # build.gradle.kts # mockito/src/test/kotlin/com/bakdata/gradle/MockitoPluginIT.kt
# Conflicts: # build.gradle.kts # jib/build.gradle.kts # mockito/build.gradle.kts # release/build.gradle.kts # sonar/build.gradle.kts # sonatype/build.gradle.kts
philipp94831
force-pushed
the
fix/dokka
branch
from
August 13, 2026 08:45
487d213 to
ebaadb4
Compare
philipp94831
marked this pull request as ready for review
August 13, 2026 11:35
philipp94831
enabled auto-merge
August 13, 2026 11:38
jkbe
reviewed
Aug 13, 2026
jkbe
approved these changes
Aug 13, 2026
There was a problem hiding this comment.
Pull request overview
Adds Dokka v2 compatibility to the Sonatype publishing plugin by wiring Dokka v2’s Javadoc-generation task into the javadocJar artifact, and expands integration testing to cover both Dokka task variants.
Changes:
- Extend Sonatype publication setup to also consume Dokka v2’s Javadoc publication task output.
- Add Gradle TestKit integration tests for a Dokka v2 (“dokka-javadoc”) project and a legacy-task (“dokkaJavadoc”) project.
- Minor import/style cleanups and test resource additions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sonatype/src/main/kotlin/com/bakdata/gradle/SonatypePlugin.kt | Recognize Dokka v2 Javadoc task name when wiring javadocJar. |
| sonatype/src/test/kotlin/com/bakdata/gradle/SonatypePluginIT.kt | Add integration tests for Dokka v2 and legacy Dokka task behavior; adjust WireMock imports. |
| sonatype/src/test/resources/Demo.kt | Add Kotlin demo source used by TestKit projects. |
| sonar/src/main/kotlin/com/bakdata/gradle/SonarPlugin.kt | Replace wildcard Kotlin DSL imports with explicit imports. |
| sonar/src/test/resources/DemoTest.java | Reorder imports for style/consistency. |
Suppressed comments (1)
sonatype/src/test/kotlin/com/bakdata/gradle/SonatypePluginIT.kt:496
- Same as in testDokka2Project: duplicating every expected upload to match a known double-upload makes the test brittle and locks in buggy behavior. Prefer asserting on the distinct uploaded files so the test remains valid if the duplication is fixed.
.flatMap { file -> listOf(file, "$file.md5", "$file.sha1", "$file.sha256", "$file.sha512") }
.flatMap { file -> listOf(file, file) } //FIXME somehow elements are uploaded twice
assertThat(getUploadedFilesInGroup(wiremock)).containsExactlyInAnyOrderElementsOf(expectedUploads)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.