[GIT PULL] liburing.h: add missing LIBURING_NOEXCEPT to inline helpers - #1637
Merged
axboe merged 1 commit intoSep 11, 2026
Merged
Conversation
io_uring_cqe_nr(), io_uring_cqe_get_data64(), io_uring_prep_pipe() and io_uring_prep_pipe_direct() are the only IOURINGINLINE helpers that are not annotated with LIBURING_NOEXCEPT. All other public inline helpers carry the annotation, so C++ consumers see these four as potentially throwing, which is inconsistent and can inhibit optimizations in noexcept contexts. Mark them like the rest of the header. Signed-off-by: Arsh Goyal <business.arshgoyal@gmail.com> Co-Authored-By: business.arshgoyal@gmail.com <business.arshgoyal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io_uring_cqe_nr(),io_uring_cqe_get_data64(),io_uring_prep_pipe()andio_uring_prep_pipe_direct()are the onlyIOURINGINLINEhelpers inliburing.hwithout theLIBURING_NOEXCEPTannotation that every other public inline helper carries. This adds it so the header is consistent and C++ callers see these asnoexceptlike the rest.Verified:
makeandmake -C testbuild warning-free,pipe.t/nop.tpass, and ag++ -std=c++17TU including the header compiles cleanly.git request-pull output:
By submitting this pull request, I acknowledge that: