fix: S3 Encryption Client malformed material description - #3411
Merged
richardwang1124 merged 6 commits intoJul 29, 2026
Merged
Conversation
added 5 commits
July 27, 2026 17:40
extract_encryption_context now raises Errors::DecryptionError when the material description parses to a non-Hash JSON value (e.g. [], true, "str", 123) or is absent, instead of leaking a downstream TypeError or NoMethodError from encryption context handling.
richardwang1124
changed the title
josecorella
commented
Jul 29, 2026
Co-authored-by: José Corella <39066999+josecorella@users.noreply.github.com>
richardwang1124
approved these changes
Jul 29, 2026
richardwang1124
left a comment
richardwang1124
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!