fix(csv-import): fire notification and clear box for failed imports without error payload - #3152
Draft
okxint wants to merge 1 commit into
Draft
fix(csv-import): fire notification and clear box for failed imports without error payload#3152okxint wants to merge 1 commit into
okxint wants to merge 1 commit into
Conversation
…mports without error payload Failed imports with empty or null errors array caused isError to be false, silently skipping the notification and leaving the import box permanently visible. Use status comparison instead of errors truthiness, and remove the completed item from importItems after notification fires so the box closes once all imports finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two bugs compounded to leave the CSV import notification box permanently visible after a failed import.
Bug 1 —
isErrorgate skipped on empty errorsshowCompletionNotificationcheckedconst isError = !isSuccess && !!payload.errors. If a failed import haderrors: null,undefined, or[],isErrorwas falsy and the function returned early — no toast notification, no cleanup.Bug 2 — import item never removed from
importItemsupdateOrAddItemcalledshowCompletionNotificationon terminal statuses but never removed the item from theimportItemsmap. Since the box is only hidden whenimportItems.size === 0, it stayed open.Fix
payload.status === 'failed'instead of!!payload.errorsto determine error state.importItemsafter the notification fires on every terminal status.Closes related open issue #2877.