fix(workflow): include coverImage in search and list API responses#6280
Merged
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces dashboard workflow-card network fan-out by including each workflow’s coverImage payload directly in workflow list/search responses, so the frontend can render card previews without per-card GET /workflow/{wid}/cover calls.
Changes:
- Backend: extend workflow search/list query builders to left-join
WORKFLOW_COVER_IMAGEand aggregate/select the cover image intoDashboardWorkflow.coverImage. - Frontend: extend dashboard workflow typings/entry mapping and switch card rendering to use the bundled
coverImagevalue instead of fetching covers per card. - Tests: add a backend test asserting cover images are present in workflow search results.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/app/dashboard/type/dashboard-workflow.interface.ts | Adds coverImage to the workflow dashboard type. |
| frontend/src/app/dashboard/type/dashboard-entry.ts | Maps backend coverImage onto DashboardEntry.coverImageUrl for card rendering. |
| frontend/src/app/dashboard/component/user/list-item/card-item/card-item.component.ts | Stops per-card cover fetch; uses bundled cover image for workflow cards. |
| amber/src/test/scala/org/apache/texera/web/resource/dashboard/file/WorkflowResourceSpec.scala | Adds regression test for cover image inclusion in search results. |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/WorkflowSearchQueryBuilder.scala | Includes cover image in workflow search query + mapping. |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowResource.scala | Includes cover image in workflow list query + DashboardWorkflow model. |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/UnifiedResourceSchema.scala | Extends unified schema to carry workflow cover image field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6280 +/- ##
============================================
+ Coverage 66.04% 66.07% +0.02%
Complexity 3380 3380
============================================
Files 1142 1142
Lines 44980 44991 +11
Branches 4948 4950 +2
============================================
+ Hits 29709 29728 +19
+ Misses 13631 13621 -10
- Partials 1640 1642 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🟢 | bs=10 sw=10 sl=64 | 548 | 0.334 | 18,360/22,234/22,234 us | 🟢 -37.3% / 🔴 +53.0% |
| 🔴 | bs=100 sw=10 sl=64 | 1,226 | 0.748 | 82,786/89,697/89,697 us | 🟢 -16.0% / 🟢 -19.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,410 | 0.861 | 710,555/741,039/741,039 us | ⚪ within ±5% / 🟢 +28.9% |
Baseline details
Latest main afa8af2 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 548 tuples/sec | 490 tuples/sec | 825.74 tuples/sec | +11.8% | -33.6% |
| bs=10 sw=10 sl=64 | MB/s | 0.334 MB/s | 0.299 MB/s | 0.504 MB/s | +11.7% | -33.7% |
| bs=10 sw=10 sl=64 | p50 | 18,360 us | 19,061 us | 12,003 us | -3.7% | +53.0% |
| bs=10 sw=10 sl=64 | p95 | 22,234 us | 35,483 us | 14,566 us | -37.3% | +52.6% |
| bs=10 sw=10 sl=64 | p99 | 22,234 us | 35,483 us | 18,190 us | -37.3% | +22.2% |
| bs=100 sw=10 sl=64 | throughput | 1,226 tuples/sec | 1,213 tuples/sec | 1,072 tuples/sec | +1.1% | +14.3% |
| bs=100 sw=10 sl=64 | MB/s | 0.748 MB/s | 0.741 MB/s | 0.654 MB/s | +0.9% | +14.3% |
| bs=100 sw=10 sl=64 | p50 | 82,786 us | 78,224 us | 94,522 us | +5.8% | -12.4% |
| bs=100 sw=10 sl=64 | p95 | 89,697 us | 106,823 us | 101,111 us | -16.0% | -11.3% |
| bs=100 sw=10 sl=64 | p99 | 89,697 us | 106,823 us | 111,122 us | -16.0% | -19.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,410 tuples/sec | 1,417 tuples/sec | 1,094 tuples/sec | -0.5% | +28.8% |
| bs=1000 sw=10 sl=64 | MB/s | 0.861 MB/s | 0.865 MB/s | 0.668 MB/s | -0.5% | +28.9% |
| bs=1000 sw=10 sl=64 | p50 | 710,555 us | 705,473 us | 934,546 us | +0.7% | -24.0% |
| bs=1000 sw=10 sl=64 | p95 | 741,039 us | 763,431 us | 975,104 us | -2.9% | -24.0% |
| bs=1000 sw=10 sl=64 | p99 | 741,039 us | 763,431 us | 1,005,414 us | -2.9% | -26.3% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,364.95,200,128000,548,0.334,18360.42,22233.94,22233.94
1,100,10,64,20,1631.61,2000,1280000,1226,0.748,82786.11,89696.58,89696.58
2,1000,10,64,20,14184.44,20000,12800000,1410,0.861,710555.17,741039.26,741039.26
xuang7
approved these changes
Jul 10, 2026
xuang7
left a comment
xuang7
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Could you add a test case for the uncovered part?
xuang7
added
release/v1.2
Contributor
Author
|
Thanks, added the requested test coverage |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
VuMartin
force-pushed
the
n-plus-one-cover-fetches
branch
from
52c9e5a to
3a61a39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Include workflow cover image data in the dashboard search response to prevent the frontend from needing additional requests to fetch cover images.
This PR fixes the N+1 query issue where each workflow card was making a separate GET /workflow/{wid}/cover request to fetch its cover image.
Before:
· The frontend loads the workflow list (1 request)
· Each card calls workflowCoverService.getCover() individually (N requests)
· Total: 1 + N requests for N workflows
After:
· /dashboard/search and workflow responses now include the coverImage field in the response
· Each card uses the bundled data directly
· Total: 1 request
Changes made:
Any related issues, documentation, discussions?
Closes #5920
Follow-up to #5704
How was this PR tested?
Manual Testing:
· Verified coverImage field appears in search responses
· Uploaded a test cover image via API and confirmed it appears in search response
Automated Tests:
· Added a test case to verify workflow cover images are included in search results.
Tested with:
sbt "project WorkflowExecutionService" "testOnly *WorkflowResourceSpec -- -z "include workflow cover image in search results""
Was this PR authored or co-authored using generative AI tooling?
Co-authored with ChatGPT 5.5-mini