Tidy up java code in o.a.s.jersey package#4658
Open
epugh wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies IntelliJ-driven cleanups across the org.apache.solr.jersey package, primarily focusing on minor refactors and small correctness/clarity improvements in request/response filters and related utilities.
Changes:
- Replaced
Class#isInstance(...)usage withinstanceofchecks in several filters. - Cleaned up unused logging-related imports/fields in a couple of classes.
- Fixed a small spelling issue in Javadoc.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| solr/core/src/java/org/apache/solr/jersey/RequestMetricHandling.java | Minor refactor of entity type check to instanceof. |
| solr/core/src/java/org/apache/solr/jersey/RequestContextKeys.java | Javadoc spelling correction (“certian” → “certain”). |
| solr/core/src/java/org/apache/solr/jersey/PostRequestLoggingFilter.java | Logging/filter cleanup, including a query-string building tweak. |
| solr/core/src/java/org/apache/solr/jersey/PostRequestDecorationFilter.java | Minor refactor of entity type check to instanceof. |
| solr/core/src/java/org/apache/solr/jersey/MediaTypeOverridingFilter.java | Removed unused logger/imports. |
| solr/core/src/java/org/apache/solr/jersey/container/JettyBridgeResponseWriter.java | Removed unused logger/imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| for (String val : entry.getValue()) { | ||
| if (sb.length() != 0) sb.append('&'); | ||
| if (!sb.isEmpty()) sb.append('&'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Go through the o.a.s.jersey and look at intellji suggestions for code cleanups.
Solution
IntelliJ inspired changes.
Tests
existing tests plus claude review.