SOLR-18315: Optimize UTF conversions by using standard Java APIs#4653
Open
psalagnac wants to merge 1 commit into
Open
SOLR-18315: Optimize UTF conversions by using standard Java APIs#4653psalagnac wants to merge 1 commit into
psalagnac wants to merge 1 commit into
Conversation
epugh
reviewed
Jul 23, 2026
| public static class BenchState { | ||
|
|
||
| @Param({"xml", "binary"}) | ||
| @Param({"xml", "javabin"}) |
Contributor
There was a problem hiding this comment.
Bug fix here? Nice to see the benchmarks get used and therefore finding oversights like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18315
Description
This replaces class
ByteUtilsby Java API calls, mostlyStringconstructor andgetBytes()method when doing short-lengthbyte[] <-> Stringconversions, or usingCharsetEncoderfor longer data.Tests
I validated the perf improvement with
RequestWritersbenchmark (note it just measures serialization of update requests, whithout processing the requests).I get a 8.5x improvement in throughput.