[python] Early partition filter in manifest reading#8429
Open
XiaoHongbo-Hope wants to merge 1 commit into
Open
[python] Early partition filter in manifest reading#8429XiaoHongbo-Hope wants to merge 1 commit into
XiaoHongbo-Hope wants to merge 1 commit into
Conversation
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
force-pushed
the
manifest_early_partition_filter
branch
from
69c176d to
c84b7bd
Compare
XiaoHongbo-Hope
force-pushed
the
manifest_early_partition_filter
branch
2 times, most recently
from
e47e38f to
68fbc07
Compare
Deserialize and test the partition predicate before building the _FILE block, skipping full deserialization for non-matching manifest entries (aligns with Java's createEntryRowFilter). Add is_in partition test over a many-partition table.
XiaoHongbo-Hope
force-pushed
the
manifest_early_partition_filter
branch
from
68fbc07 to
8e4b7f0
Compare
JingsongLi
reviewed
Jul 2, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
The test_partition_filter_test_handles_isnull only directly tests the Predicate on full table rows and does not cover the newly added early manifest path: partition_filter.test(partition). If issues arise with the index space of partition-only rows or null deserialization, this test will still pass. It is recommended to modify or supplement with an actual scan: write pt=None and pt='x', and use with_filter(pb.is_null('pt')).new_scan().plan() to assert that only null partitions are retained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Tests