[test]Fix resource leak in CompressUtils.gzipCompressFile#8396
Open
cxzl25 wants to merge 1 commit into
Open
Conversation
JingsongLi
reviewed
Jul 1, 2026
| return result; | ||
| } | ||
|
|
||
| private static void gzipCompressFile(String src, String dest) throws IOException { |
Contributor
There was a problem hiding this comment.
Making this helper local to the Hive test leaves another caller broken. paimon-spark/paimon-spark-ut/src/test/scala/org/apache/paimon/spark/sql/FormatTableTestBase.scala still imports org.apache.paimon.utils.CompressUtils and calls CompressUtils.gzipCompressFile, so deleting the core class will make the Spark test module fail to compile. Please either move the helper to a shared test utility used by both modules, or update the Spark test to use its own/local helper as well.
fix [test] Move gzip helper from core production code to hive test
cxzl25
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The original
CompressUtils.gzipCompressFileimplementation only closedstreams on the happy path. If an
IOExceptionwas thrown after the streamswere opened, none of them would be closed, causing a resource leak.
try-with-resourcessoFileInputStream,FileOutputStream,and
GZIPOutputStreamare always closed regardless of whether an exceptionoccurs
CompressUtilsis kept inpaimon-core/src/main/javabecause it is used byboth
HiveCatalogFormatTableITCaseBase(Hive IT) andFormatTableTestBase(Spark UT)
Tests
GHA