IGNITE-28588 update Spring#13267
Closed
nao-it wants to merge 14 commits into
Closed
Conversation
This reverts commit 247963e.
IGNITE-28807 Fix tests in jta after update Spring
zstan
reviewed
Jul 7, 2026
| * <p> | ||
| * Each wrapper instance has its own state (not shared between parallel tests). | ||
| */ | ||
| public class TransactionManagerWrapper implements TransactionManager { |
Contributor
There was a problem hiding this comment.
I missunderstand why do you need this wrapper under TransactionImple ? Plz explain ?
| <javax.cache.bundle.version>1.0.0_1</javax.cache.bundle.version> | ||
| <javax.cache.tck.version>1.1.1</javax.cache.tck.version> | ||
| <javax.cache.version>1.0.0</javax.cache.version> | ||
| <jboss.rmi.version>1.0.6.Final</jboss.rmi.version> |
Contributor
There was a problem hiding this comment.
why we need to remove it ? i store it as is, apply all other changes and also not append : <narayana.version>7.3.4.Final</narayana.version> and tests seems ok, did i miss smth ?
| <excludes> | ||
| <exclude>javax.transaction:jta</exclude> | ||
| <exclude>javax.transaction:javax.transaction-api</exclude> | ||
| <exclude>jakarta.transaction:jakarta.transaction-api:(,2.0.0)</exclude> |
Comment on lines
+1020
to
+1023
| catch (LinkageError e) { | ||
| U.warn(log, "Failed to initialize HTTP REST protocol (consider adding ignite-rest-http " + | ||
| "module and its dependencies to classpath): " + e); | ||
| } |
Comment on lines
60
to
78
| @@ -75,7 +75,6 @@ else if (target.startsWith("/logo.svg")) { | |||
| res.getOutputStream().flush(); | |||
|
|
|||
| res.setStatus(HttpServletResponse.SC_OK); | |||
| req.setHandled(true); | |||
| } | |||
| @Override public void testLifecycleAware() throws Exception { | ||
| // No-op, see anothre tests. | ||
| @Override public void testLifecycleAware() { | ||
| // No-op, see another tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.