Kafka Connect: Include connector name in commit thread names#17033
Open
hutiefang76 wants to merge 1 commit into
Open
Kafka Connect: Include connector name in commit thread names#17033hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
Include the connector name in Kafka Connect coordinator and committer thread names so thread dumps are easier to attribute when multiple connectors run in the same worker. Generated-by: Codex GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16354.
This updates the Kafka Connect sink commit thread names to include the connector name:
iceberg-coord-<connector-name>when started by a committericeberg-committer-<connector-name>-%dThis makes thread dumps and worker logs easier to attribute when multiple Iceberg sink connectors run in the same Kafka Connect worker. The existing package-private
CoordinatorThread(Coordinator)constructor is kept unchanged for existing tests/internal callers.Validation:
JAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :iceberg-kafka-connect:iceberg-kafka-connect:test --tests org.apache.iceberg.connect.channel.TestCoordinatorThread --tests org.apache.iceberg.connect.channel.TestCommitterImpl --no-daemonJAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :iceberg-kafka-connect:iceberg-kafka-connect:spotlessCheck --no-daemongit diff --checkAI Disclosure