HIVE-28329: Fix vectorized col * CASE decimal multiply returning zero#6575
Merged
Conversation
kokila-19
changed the title
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
kokila-19
marked this pull request as ready for review
July 7, 2026 08:08
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests passed
tests pending
tests unstable
labels
kasakrisz
reviewed
Jul 10, 2026
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
tests passed
and removed
tests pending
tests failed
labels
Contributor
Author
|
There are sonar issues, I will work on resolving them and have green tests. |
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
Contributor
Author
|
@kasakrisz Sonar issues are not related to this PR. |
kasakrisz
reviewed
Jul 22, 2026
kasakrisz
left a comment
kasakrisz
left a comment
Contributor
There was a problem hiding this comment.
Looks good left one question about testing with a simpler query.
Preserve inputColumnNum column refs when re-instantiating DECIMAL parents after DECIMAL_64 child conversion and refresh projectedOutputColumns.
|
kasakrisz
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix HIVE-28329 in Vectorizer.java: preserve column inputs when re-instantiating DECIMAL multiply after DECIMAL_64→DECIMAL conversion and refresh projectedOutputColumns.
Added qtest vector_decimal64_col_multiply_case_subquery_join.q.
Why are the changes needed?
With CBO and vectorization enabled, expressions like col3 * CASE(...) are vectorized with the CASE as DECIMAL_64 and the multiply expecting DECIMAL. When fixDecimalDataTypePhysicalVariations() wraps the CASE with ConvertDecimal64ToDecimal and re-builds the multiply, the old code only used child expressions. So, col3 in inputColumnNum[] was dropped and a stale scratch column (often 0) was used instead.
That led to wrong multiply inputs and stale projectedOutputColumns, so HIVE-28329 returned 0.000000000 instead of 0.000197260.
Disabling vectorization avoided this broken path.
Does this PR introduce any user-facing change?
Yes, a bug fix. Affected queries now return correct decimal results. No new config or syntax.
How was this patch tested?
qtest: vector_decimal64_col_multiply_case_subquery_join.q
Manual test: EXPLAIN before/after to confirm multiply wiring col2, col19 vs col19, col9