HBASE-30267 Backport HBASE-30266 Do not drop visibility delete marker…#8448
Open
liuxiaocs7 wants to merge 1 commit into
Open
HBASE-30267 Backport HBASE-30266 Do not drop visibility delete marker…#8448liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
…s as redundant during minor compaction to branch-2
There was a problem hiding this comment.
Pull request overview
This PR backports the HBASE-30266 fix to branch-2 to ensure that, on cell-visibility tables, delete markers are not incorrectly treated as redundant during minor compaction (which could otherwise resurrect data that must remain deleted).
Changes:
- Override
VisibilityScanDeleteTracker#isRedundantDeleteto conservatively returnfalsefor all delete markers on visibility tables. - Add a focused unit test to pin the “never redundant” contract for visibility delete tracking.
- Add an end-to-end regression test that exercises minor-compaction behavior to ensure differently-labeled delete markers are retained.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java |
Forces isRedundantDelete to always return false to prevent label-blind redundancy pruning during minor compaction. |
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityScanDeleteTracker.java |
Adds unit coverage asserting visibility delete markers are never reported redundant (including same-label and label-less cases). |
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java |
Adds an end-to-end regression test ensuring differently-labeled delete markers survive minor compaction and prevent data resurrection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s as redundant during minor compaction to branch-2