[spark] Add input argument validation with friendly errors to CALL procedure framework#3689
Open
XuQianJin-Stars wants to merge 1 commit into
Open
Conversation
…ocedure framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Introduce reusable input-argument validation helpers in the Spark
CALLprocedure base class so that procedures fail fast with clear, user-facing error messages when a required parameter is missing or its type does not match the declared parameter spec.Brief change log
BaseProcedure:checkRequiredArgument(parameter, provided): throws anIllegalArgumentExceptionwith a descriptive message when a required parameter is not supplied.checkArgumentType(parameter, value): throws anIllegalArgumentExceptionwhen the supplied value's type does not match the declared parameter type.GetClusterConfigsProcedure.callnow invokes these helpers to validate theconfig_keysarray parameter before execution.GetClusterConfigsProcedureTest) asserting a type-mismatched argument is rejected.Tests
GetClusterConfigsProcedureTest:get_cluster_configs: rejects wrong argument type for config_keys— verifies that passing a scalarSTRINGwhere anARRAYis expected fails with a friendly error instead of a cryptic internal failure.API and Format
Documentation