[FLINK-40111][table] Fall back to retract for a keyless sink without an upsert key - #28704
Merged
Conversation
…an upsert key A sink without a primary key that advertises an upsert changelog (ONLY_UPDATE_AFTER) can only apply UPDATE_AFTER when the input carries an upsert key for the downstream to fold by. When the input has no upsert key, fall back to BEFORE_AND_AFTER so the query plans as retract (when the input can produce UPDATE_BEFORE) instead of emitting an unkeyed upsert stream. Keyed-sink behavior is unchanged. Generated-by: Claude Opus 4.8 (Claude Code)
Collaborator
twalthr
approved these changes
Jul 10, 2026
twalthr
left a comment
Contributor
There was a problem hiding this comment.
The change looks good to me. This edge case behavior was undefined before and by looking at the test also untested. The change is a good preparation for developing a more dynamic collect() sink in the future that does not dictate retract but dynamically adjusts to what the upstream pipeline actually demands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A sink without a primary key that advertises an upsert changelog (ONLY_UPDATE_AFTER) can only apply UPDATE_AFTER when the input carries an upsert key for the downstream to fold by. When the input has no upsert key, the planner now falls back to BEFORE_AND_AFTER so the query plans as retract (when the input can produce UPDATE_BEFORE) instead of emitting an unkeyed upsert stream. Keyed-sink behavior is unchanged.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
2.1.196 (Claude Code) with Opus 4.8