fix: mark CsvCell Calendar value as a date to avoid silent empty write - #974
Open
Aias00 wants to merge 1 commit into
Open
fix: mark CsvCell Calendar value as a date to avoid silent empty write#974Aias00 wants to merge 1 commit into
Aias00 wants to merge 1 commit into
Conversation
apache#973) setCellValueImpl(Calendar) set cellType=NUMERIC but did not set numericCellType=DATE, so CsvSheet.buildCellValue took the number branch, found numberValue null, and wrote an empty field - silently dropping the Calendar value. Mirrors the Date and LocalDateTime setters. Add an integration test that writes a Calendar and reads the CSV back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #973.
CsvCell.setCellValueImpl(Calendar)setcellType = NUMERICbut did not setnumericCellType = NumericCellTypeEnum.DATE, soCsvSheet.buildCellValuetook the number branch, foundnumberValuewasnull, and wrote an empty field — silently dropping theCalendarvalue. The siblingDateandLocalDateTimesetters already set the date type.Root cause
CsvCell:CsvSheet.buildCellValuedispatches oncsvCell.getNumericCellType() == NumericCellTypeEnum.DATE; without it the cell falls through to the number branch, wherenumberValueisnull, and returnsnull→ empty field.Fix
Verification
Added
CsvRowTest.csvWrite_withCalendar_producesCorrectFile: writes aCalendar(2024-01-15 12:30:45) to aCsvCellvia the POICellAPI and reads the CSV file back. Before the fix the cell was an empty field; after the fix the line contains2024-01-15. Fullfesod-sheetsuite:Tests run: 668, Failures: 0.