fix: copy default read converter map to isolate per-reader custom converters - #972
Open
Aias00 wants to merge 4 commits into
Open
fix: copy default read converter map to isolate per-reader custom converters#972Aias00 wants to merge 4 commits into
Aias00 wants to merge 4 commits into
Conversation
…verters (apache#971) The workbook-level read holder aliased DefaultConverterLoader's shared static allConverter map instead of copying it, so custom converters registered via registerConverter() were put() into the global map and leaked into every later, unrelated read on the same JVM. Mirror the write side (AbstractWriteHolder:271), which already copies, and add a regression test.
Aias00
force-pushed
the
fix/read-converter-isolation-971
branch
from
July 27, 2026 13:36
a2c6303 to
b36f79f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #971.
The workbook-level read holder aliased
DefaultConverterLoader's shared staticallConvertermap instead of copying it, so custom converters registered viaregisterConverter(...)wereput()into the global map and leaked into every later, unrelated read on the same JVM. This mirrors the write side (AbstractWriteHolder:271), which already copies.Root cause
AbstractReadHolder:loadDefaultReadConverter()returns the staticallConvertermap by reference, so thegetConverterMap().put(...)loop right below mutates the shared map and the registration survives the reader.Fix
Verification
Added
ReadConverterIsolationTestwhich:Before the fix, step 2 failed (
hello [MARKER]instead ofhello). After the fix it passes. Fullfesod-sheetsuite:Tests run: 668, Failures: 0, Errors: 0.