Add IN list sqllogictest test (and integer type coverage)#23305
Conversation
geoffreyclaude
left a comment
There was a problem hiding this comment.
Very clear and hits quite a few edge cases. Could you just extend the tests to also include longer in lists (eg, 12 elements)?
71a568f to
b801c50
Compare
Done |
|
I also added a note to point out that the IN list is only executed for larger lists (over 4) |
We'll have to review that optimization rule once the full IN LIST optims land! |
Indeed At some point stuff like PruningPredicate didn't know how to handle IN lists either -- but I believe now that IN LIST is handled quite well at this point across the system |
Which issue does this PR close?
Rationale for this change
We (mostly @geoffreyclaude ) are in the process of optimizing IN lists with specialized implementations for various different data types.
@kosiew suggested in #23299 (comment) that we add SQL level coverage for the IN list optimizations to both cover the dispatch logic as well as ensure everything works end to end.
What changes are included in this PR?
in_list.sltfile to specifically target the IN listsnote I think we should have significiantly more SLT coverage (list on #23307) but to keep the review small / understandable I plan to do it with several PRs
Are these changes tested?
Only tests
Are there any user-facing changes?
No