feat: Support duration type in approx_distinct#23291
Open
mkleen wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
sqllogictest
mkleen
force-pushed
the
duration_approx_distinct
branch
2 times, most recently
from
4749a7d to
87049df
Compare
mkleen
force-pushed
the
duration_approx_distinct
branch
from
87049df to
98a25ce
Compare
mkleen
changed the title
Jefffrey
reviewed
Jul 3, 2026
|
|
||
| // --- Duration benchmarks --- | ||
| let values = Arc::new(create_duration_array(n_distinct)) as ArrayRef; | ||
| c.bench_function(&format!("approx_distinct duration {pct}% distinct"), |b| { |
Contributor
There was a problem hiding this comment.
honestly i feel we dont need to add a benchmark for this; it would be good to cut down on the benchmarks as having too many results can be too noisy, especially as the codepath being tested here would be the same for all primitives anyway 🤔
| } | ||
|
|
||
| #[test] | ||
| fn duration_support_numerical_acc_and_group_acc() { |
Contributor
There was a problem hiding this comment.
we could probably omit this test since we have the SLT? or is this to handle the MAX/MIN cases?
Contributor
Author
There was a problem hiding this comment.
yes sure we could just go with the SLT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
approx_distinctfunction #22989 but does not close it. More types are coming.Rationale for this change
Durationtype forapprox_distinctDurationcan be directly supported forNumericHLLAccumulatorandHllGroupsAccumulatorWhat changes are included in this PR?
NumericHLLAccumulatorandHllGroupsAccumulatorto supportDurationapprox_distinct.rstandaggregate.sltAre these changes tested?
Yes
Are there any user-facing changes?
Yes,
approx_distinctsupports nowDurationbut no breaking changes.