Snowflake: Parse structured OBJECT types - #2489
Open
osipovartem wants to merge 3 commits into
Open
Conversation
iffyio
reviewed
Sep 10, 2026
iffyio
reviewed
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake structured OBJECT types can contain named, nullable or
NOT NULLfields and recursively nested OBJECT types. The genericCustom(Vec<String>)representation loses these boundaries.This adds
DataType::Object(Vec<ColumnDef>), a Snowflake dialect capability, recursive parsing and formatting, and leaves unstructuredOBJECTunchanged.Validated against:
https://docs.snowflake.com/en/sql-reference/data-types-structured#structured-object-types
Tests cover nested types,
NOT NULLAST preservation, unstructuredOBJECT, and malformed definitions.AI assistance: Codex was used to prepare the implementation and tests.