chore: drop Spark 3.4 support - #5358
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
| value: | | ||
| org.apache.comet.exec.CometAggregateSuite | ||
| org.apache.comet.exec.CometExec3_4PlusSuite | ||
| org.apache.comet.exec.CometExecCompatibilitySuite |
There was a problem hiding this comment.
Yes, CometExecCompatibilitySuite is renamed from CometExec3_4PlusSuite and used by all supported Spark versions.
|
@andygrove @coderfender @comphead I'd appreciate your review here. |
|
Sure! Thank you for the pr @manuzhang |
There was a problem hiding this comment.
Thanks @manuzhang
this is def on the table, however lets keep this PR opened for now.
There are some pending use cases still using 3.4.3, I would propose doing this in parts.
Currently it would make sense to:
- remove 3.4 from CI
- Add a warn message saying 3.4 support would be dropped in 1.1.0
- update roadmap
|
@comphead It's already announced in 1.0.0 release blog.
Where else do we need to add a warn message and update? |
I was thinking to add a warn runtime message that Spark 3.4 support is sunsetting. Not sure if it makes sense though. But still I would propose doing a soft drop:
Keep the code for couple of more weeks and drop it closer to the dedicated release date |
|
What does the community think about retaining the code for 3.4 (but maybe relaxed ci and backporting of fixes)? We have a ton of users (and even more production jobs) still on 3.4. |
Which issue does this PR close?
Closes #4329.
Rationale for this change
Spark 3.4 was deprecated in Comet 1.0.0 and is scheduled for removal in 1.1.0. Dropping it reduces the supported build/test matrix and removes compatibility paths that are no longer needed now that Spark 3.5 is the oldest supported release.
What changes are included in this PR?
How are these changes tested?
make format PROFILES=-Pspark-3.5./mvnw clean test-compile -DskipTests -Pspark-4.0./mvnw clean test-compile -DskipTests -Pspark-4.1./mvnw clean test-compile -DskipTests -Pspark-4.2CometTPCDSV1_4_PlanStabilitySuiteon Spark 3.5 (97 tests)CometTPCDSV2_7_PlanStabilitySuiteon Spark 3.5 (32 tests)git diff --checkvalidation