COLLECTIONS-900: IteratorChain#addIterator() does not work properly with IteratorChain parameters

[mbaedke]

Added failing test case.

[garydgregory]

main and test changes don't match as the build fails in tests.

[garydgregory]

@mbaedke
The build fails.

[garydgregory]

Jira ticket is COLLECTIONS-900.

[mbaedke]

Thx @garydgregory , fixed it.

[garydgregory]

@mbaedke
Thank you for the update.
I think we need more tests to verify nothing breaks for the full sequence, exhaustion, remove(), empty leading iterators, and rechaining after at least one successful next() call.

[mbaedke]

@mbaedke Thank you for the update. I think we need more tests to verify nothing breaks for the full sequence, exhaustion, remove(), empty leading iterators, and rechaining after at least one successful next() call.

Yes, I'll get that done by EOW

[mbaedke]

I think we need more tests to verify nothing breaks for the full sequence, exhaustion, remove(), empty leading iterators, and rechaining after at least one successful next() call.

@garydgregory : Sorry for the late response. After thinking about it: this PR together with #628 fundamentally change the way addIterator() treats ChainedIterators. Wouldn't it be very reasonable to parameterize the test so that it runs a second time with makeObject() creating a chain of ChainedIteraors instead of ListIterators?