.asf.yaml: add PR merge requirements - #14057
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The required checks list omits the separate “Simulator CI / test” job, which can allow merges even when simulator tests fail.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the ASF GitHub repository configuration to enforce stricter merge gates on the default branch, by requiring a minimum number of PR approvals and specific CI checks to pass before merging.
Changes:
- Require at least 2 approving PR reviews before merge.
- Require a set of named GitHub Actions status checks (Build, pre-commit, UI Build, Simulator CI, License Check) before merge.
File summaries
| File | Description |
|---|---|
.asf.yaml |
Adds branch protection merge requirements (review count + required CI status checks). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The PR title/description do not match the actual code change, making the PR intent unclear for review and auditability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
cf9e115 to
f7cdd1f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-test #14057 +/- ##
============================================
Coverage ? 19.78%
Complexity ? 19996
============================================
Files ? 6371
Lines ? 575899
Branches ? 70495
============================================
Hits ? 113961
Misses ? 449509
Partials ? 12429
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.68% |
| Branch coverage | 18.89% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?