CASSANDRA-21527: Make runWithCompactionsDisabled return non-null on success - #4948
Open
nivykani wants to merge 4 commits into
Open
CASSANDRA-21527: Make runWithCompactionsDisabled return non-null on success#4948nivykani wants to merge 4 commits into
nivykani wants to merge 4 commits into
Conversation
nivykani
force-pushed
the
truncate
branch
2 times, most recently
from
July 21, 2026 23:57
64ae491 to
905c729
Compare
Fix flaky test to wait for the index Formatting Fix test Fix test
smiklosovic
reviewed
Jul 30, 2026
| try | ||
| { | ||
| // submitMaximal should no-op on null getMaximalTasks result | ||
| var futures = CompactionManager.instance.submitMaximal(cfs, false, -1); |
Contributor
There was a problem hiding this comment.
@nivykani could you please change var to a concrete type, you will most probably hit this when trying to backport this to lower branches anyway.
Author
There was a problem hiding this comment.
Fixed by inlining, since futures is only used once anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, runWithCompactionsDisabled can’t tell the difference between a successful truncate vs a truncate that wasn’t successful due to being unable to stop compaction, because both return null. In either case, it logs “Truncate is complete” and returns success to the user.
TruncateBlockingTestreproduces this bug.The proposed fix is adding a return value to check for success on truncateBlocking, as well as adding a new exception type for Truncate.
The Cassandra Jira