Document MockEndpoint timed assertions in AGENTS.md - #24496
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
reviewed
Jul 7, 2026
Contributor
|
ℹ️ CI did not run targeted module tests. 🔬 Scalpel shadow comparison — Scalpel: 644 tested, 29 compile-only — current: 0 all testedMaveniverse Scalpel detected 673 affected modules (current approach: 0).
|
…or mock-based waits Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
davsclaus
force-pushed
the
enhance-claude-md-mock-assertions
branch
from
July 8, 2026 05:13
aa020d1 to
fcdf556
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
davsclaus
approved these changes
Jul 8, 2026
9 tasks
…aitility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
orpiske
approved these changes
Jul 8, 2026
oscerd
approved these changes
Jul 8, 2026
oscerd
left a comment
oscerd
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I verified the documented MockEndpoint guidance against components/camel-mock/.../MockEndpoint.java:
- The timed static overload
assertIsSatisfied(context, 10, TimeUnit.SECONDS)exists and simply setsresultWaitTimethen calls the no-arg assert. - The "already waits ~10s internally" note is accurate:
resultWaitTimedefaults to 0 andwaitForCompleteLatch(0)falls back to a 10s wait, so the timed overload is only needed for a different timeout. - The latch /
CountDownLatchcharacterization and thegetReceivedCounter()-based Awaitility example for mid-test synchronization are correct.
Since CLAUDE.md is a symlink to AGENTS.md, the single edit covers both. Already approved by two committers; adding mine.
Reviewed with Claude Code on behalf of Andrea Cosentino. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude Code on behalf of Guillaume Nodet
MockEndpoint'sbuilt-in timed assertions (
assertIsSatisfied(context, timeout, unit)) over wrapping withAwaitility when the wait condition is "mock expectations are met"
MockEndpoint cannot express, e.g.
mock.getReceivedCounter() >= N)This came up during review of #24304, where
Thread.sleep()was being replaced withawait().untilAsserted(() -> MockEndpoint.assertIsSatisfied(...))— which is redundant becauseMockEndpoint's assertion is already latch-based internally.
Test plan
🤖 Generated with Claude Code