ci: fix Scalpel shadow comparison accuracy - #24378
Merged
Merged
Conversation
Two fixes: 1. Scalpel shadow comparison now compares against the full current detection (file-path + grep + -amd reactor), not just the grep POM results. Shows set differences: modules only Scalpel found (current missed) and vice versa. Summary line shows how many modules Scalpel would test vs compile-only, compared to current which tests all. 2. Fix duplicate entries in "All tested modules" list caused by long module names (e.g. "CSimple Maven Plugin (deprecated)") where Maven output has no dots between name and status, leaving "SUCCESS"/"FAILURE"/"SKIPPED" attached to the module name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
Jul 2, 2026
gnodet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Scalpel shadow comparison to give accurate results:
-amdexpansion).EXCLUSION_LIST. Scalpel already filters these viaskipTestsForDownstreamModules. This gave misleading results like "37 modules only current approach found" when those 37 aren't actually tested. Now filtersreactor_idsthroughEXCLUSION_LISTbefore comparing — apples-to-apples.CSimple Maven Plugin (deprecated)hadSUCCESS/FAILURE/SKIPPEDattached. Added explicit stripping.Also improves the shadow comparison output:
Scalpel: N tested, M compile-only — current: X all testedClaude Code on behalf of @gnodet
Test plan
🤖 Generated with Claude Code