Skip to content

chore: print a confirmation when adding a camel-jbang plugin#24366

Merged
davsclaus merged 1 commit into
apache:mainfrom
ammachado:plugin-add-confirmation
Jul 2, 2026
Merged

chore: print a confirmation when adding a camel-jbang plugin#24366
davsclaus merged 1 commit into
apache:mainfrom
ammachado:plugin-add-confirmation

Conversation

@ammachado

@ammachado ammachado commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

PluginAdd (the camel plugin add command) now prints a Plugin <name> added message after saving the plugin configuration, so adding or upgrading a plugin gives visible feedback on the terminal.

This restores symmetry with PluginDelete, which already prints a Plugin <name> removed confirmation.

The PluginAddTest assertions were updated accordingly: they previously expected empty output and now assert the confirmation message.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

Claude Code (Opus 4.8) on behalf of Adriano Machado

🤖 Generated with Claude Code

PluginAdd now prints a "Plugin <name> added" message so adding or upgrading a
plugin gives visible feedback. This restores symmetry with PluginDelete, which
already prints a "Plugin <name> removed" confirmation.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added the dsl label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • dsl/camel-jbang/camel-jbang-core

⚠️ Some tests are disabled on GitHub Actions (@DisabledIfSystemProperty(named = "ci.env.name")) and require manual verification:

  • dsl/camel-jbang/camel-jbang-core: 1 test(s) disabled on GitHub Actions

💡 Manual integration tests recommended:

You modified dsl/camel-jbang/camel-jbang-core. The related integration tests in dsl/camel-jbang/camel-jbang-it are excluded from CI. Consider running them manually:

mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
All tested modules (7 modules)
  • Camel :: JBang :: Core
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container

⚙️ View full build and test results

@ammachado ammachado marked this pull request as ready for review July 2, 2026 04:20
@davsclaus davsclaus merged commit cd6c8dd into apache:main Jul 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants