ARTEMIS-3164 Move temporary prefix support from STOMP into the core session#6591
Open
anmol-saxena-14 wants to merge 5 commits into
Open
ARTEMIS-3164 Move temporary prefix support from STOMP into the core session#6591anmol-saxena-14 wants to merge 5 commits into
anmol-saxena-14 wants to merge 5 commits into
Conversation
…oraryAnycastPrefix/temporaryMulticastPrefix.
# Conflicts: # artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompConnection.java
anmol-saxena-14
marked this pull request as ready for review
July 21, 2026 16:57
Contributor
Author
|
Link to earlier PR which got closed : #6378 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves temporaryAnycastPrefix/temporaryMulticastPrefix out of STOMP-only code and into the core session, matching how anycastPrefix/multicastPrefix already work for every protocol. Also fixes STOMP's early prefix-stripping losing the temporary signal, and a cleanup bug where a temporary address created under a prefix was never deleted on disconnect.
Verified with: new TemporaryPrefixTest (5, Core client, no STOMP), StompTemporaryPrefixTest (8), full StompTest (103) and StompV12Test (79) regression, CoreClientTest, AmqpDurableReceiverReconnectWithMulticastPrefixTest, ServerSessionImplTest, HangConsumerTest, OrphanedConsumerDefenseTest — all passing.