GH-50087: [Docs][C++] [Docs][C++] Fix sentence structure in memory.rst regarding MemoryManager#50324
Open
OmBiradar wants to merge 1 commit into
Open
GH-50087: [Docs][C++] [Docs][C++] Fix sentence structure in memory.rst regarding MemoryManager#50324OmBiradar wants to merge 1 commit into
MemoryManager#50324OmBiradar wants to merge 1 commit into
Conversation
* Removes a duplicate line * Minor grammer fix Signed-off-by: OmBiradar <ombiradar04@gmail.com>
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the C++ memory documentation by removing a duplicated sentence fragment in the arrow::Device / arrow::MemoryManager explanation, improving readability without changing meaning.
Changes:
- Removed a duplicated/redundant description of
arrow::MemoryManagerallocation behavior. - Left the remaining paragraph with a single, clear example referencing
arrow::MemoryPoolon the CPU.
Contributor
Author
|
cc: @amoeba |
arrow::MemoryManagerarrow::MemoryManager
Member
|
Hey @OmBiradar, thanks for the PR. The patch looks good. Before we approve and merge, could you make some changes to the issue title and PR title to help maintainers and future contributors out?
|
arrow::MemoryManagermemory.rst regarding MemoryManager
Contributor
Author
|
Hey @amoeba I have changed the titles of both the PR and the Issue. Let me know if its ok. I will keep in mind the points you mentioned in all my future PR's and issues raised. Thanks for the help! |
memory.rst regarding MemoryManagerMemoryManager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In file
docs/source/cpp/memory.rst:Rationale for this change
I believe the statement
was repeated twice and there was some grammatical mistake in the same paragraph
MemoryManager#50087