MINOR: [R] Unset MAKEFLAGS for nested libarrow CMake build by rok · Pull Request #50317 · apache/arrow

rok · 2026-07-01T12:46:21Z

Rationale for this change

What changes are included in this PR?

Bash command used is adjusted to prevent this error.

/usr/bin/cmake --build . --target install -- -j 2
gmake: the '-j' option requires a positive integer argument

Are these changes tested?

By CI.

Are there any user-facing changes?

No.

Copilot

Pull request overview

This PR updates the R static Arrow build script to pass the Make/Ninja parallelism flag in a single token (-jN) to avoid cases where the underlying build tool interprets -j as missing its integer argument.

Changes:

Adjusted the cmake --build invocation to use -j${N_JOBS} instead of -j $N_JOBS.

rok · 2026-07-01T12:52:41Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-01T12:54:58Z

Revision: 6d4a25b

Submitted crossbow builds: ursacomputing/crossbow @ actions-a4227cb8da

Task	Status
test-r-wasm

rok · 2026-07-01T13:15:18Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-01T13:17:36Z

Revision: 1d835a6

Submitted crossbow builds: ursacomputing/crossbow @ actions-c381cbcd47

Task	Status
test-r-wasm

rok · 2026-07-01T13:35:28Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-01T13:38:30Z

Revision: ef59f03

Submitted crossbow builds: ursacomputing/crossbow @ actions-52b31fc83d

Task	Status
test-r-wasm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

rok · 2026-07-01T14:00:06Z

@github-actions crossbow submit test-r-wasm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

github-actions · 2026-07-01T14:02:25Z

Revision: 4f135a1

Submitted crossbow builds: ursacomputing/crossbow @ actions-ea2f0ed863

Task	Status
test-r-wasm

rok · 2026-07-01T21:39:41Z

@thisisnic this change might solve the other r-wasm issue.

kou · 2026-07-02T02:10:50Z

    ${SOURCE_DIR}

-${CMAKE} --build . --target install -- -j $N_JOBS
+(unset MAKEFLAGS MFLAGS; ${CMAKE} --build . --target install --parallel "${N_JOBS}")


It seems that this

diff --git a/r/inst/build_arrow_static.sh b/r/inst/build_arrow_static.sh index 349531b75f..02bc4a24c7 100755 --- a/r/inst/build_arrow_static.sh +++ b/r/inst/build_arrow_static.sh @@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \ -G "${CMAKE_GENERATOR:-Unix Makefiles}" \ ${SOURCE_DIR} -${CMAKE} --build . --target install -- -j $N_JOBS +${CMAKE} --build . --target install -- -j$N_JOBS if command -v sccache &> /dev/null; then echo "=== sccache stats after the build ==="

or

diff --git a/r/inst/build_arrow_static.sh b/r/inst/build_arrow_static.sh index 349531b75f..0df5240888 100755 --- a/r/inst/build_arrow_static.sh +++ b/r/inst/build_arrow_static.sh @@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \ -G "${CMAKE_GENERATOR:-Unix Makefiles}" \ ${SOURCE_DIR} -${CMAKE} --build . --target install -- -j $N_JOBS +${CMAKE} --build . --target install --parallel $N_JOBS if command -v sccache &> /dev/null; then echo "=== sccache stats after the build ==="

is enough.

So if change that I get:

+ /usr/bin/cmake --build . --target install --parallel 2 gmake: the '-j' option requires a positive integer argument

and this error on crossbow test-r-wasm. Will try other combinations.

Oh, sorry...

Oh no worries. Do you think we shouldn't use unset MAKEFLAGS MFLAGS;? I'm trying things but didn't find anything useful yet.

rok · 2026-07-02T18:06:11Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-02T18:08:23Z

Revision: d7a63bc

Submitted crossbow builds: ursacomputing/crossbow @ actions-5c1be3e405

Task	Status
test-r-wasm

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

rok · 2026-07-02T18:21:03Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-02T18:23:15Z

Revision: f217bd2

Submitted crossbow builds: ursacomputing/crossbow @ actions-9c6ebe2932

Task	Status
test-r-wasm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

+    # Extract -j/--jobs value from existing MAKEFLAGS if present
+    j_match <- regmatches(makeflags, regexpr("(^|\\s)(-j\\s*|--jobs(=|\\s)+)([0-9]+)(?=\\s|$)", makeflags, perl = TRUE))
    if (length(j_match) > 0) {
-      ncores <- as.integer(sub("-j\\s*", "", j_match, perl = TRUE))
+      ncores <- as.integer(sub(".*?([0-9]+)$", "\\1", j_match, perl = TRUE))
    }
+    # Keep GNU make's optional -j/--jobs argument in one token for nested gmake
+    makeflags <- gsub("(^|\\s)-j\\s+([0-9]+)(?=\\s|$)", "\\1-j\\2", makeflags, perl = TRUE)
+    makeflags <- gsub("(^|\\s)--jobs\\s+([0-9]+)(?=\\s|$)", "\\1--jobs=\\2", makeflags, perl = TRUE)
+    # Give any remaining bare `-j`/`--jobs` an explicit count
+    makeflags <- gsub("(^|\\s)-j(?=\\s|$)", sprintf("\\1-j%s", ncores), makeflags, perl = TRUE)
+    makeflags <- gsub("(^|\\s)--jobs(?=\\s|$)", sprintf("\\1--jobs=%s", ncores), makeflags, perl = TRUE)
+    Sys.setenv(MAKEFLAGS = makeflags)


rok · 2026-07-02T19:43:59Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-02T19:46:18Z

Revision: f217bd2

Submitted crossbow builds: ursacomputing/crossbow @ actions-f3c262033f

Task	Status
test-r-wasm

rok · 2026-07-02T20:20:38Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-02T20:22:52Z

Revision: 7999054

Submitted crossbow builds: ursacomputing/crossbow @ actions-40d2949078

Task	Status
test-r-wasm

rok · 2026-07-02T22:14:45Z

@github-actions crossbow submit test-r-wasm

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

+  makeflags <- gsub("(^|\\s)--jobserver-[^[:space:]]+", " ", makeflags, perl = TRUE)
+  makeflags <- gsub("(^|\\s)--jobs(=|\\s+)?[0-9]*(?=\\s|$)", " ", makeflags, perl = TRUE)
+  makeflags <- gsub("(^|\\s)-j\\s*[0-9]*(?=\\s|$)", " ", makeflags, perl = TRUE)
+  makeflags <- gsub("(^|\\s)([[:alpha:]]*)j[0-9]*([[:alpha:]]*)(?=\\s|$)", "\\1\\2\\3", makeflags, perl = TRUE)


github-actions · 2026-07-02T22:17:07Z

Revision: a623cf5

Submitted crossbow builds: ursacomputing/crossbow @ actions-05773104a1

Task	Status
test-r-wasm

Copilot AI review requested due to automatic review settings July 1, 2026 12:46

rok requested review from jonkeane and thisisnic as code owners July 1, 2026 12:46

github-actions Bot added the Component: R label Jul 1, 2026

Copilot started reviewing on behalf of rok July 1, 2026 12:46 View session

github-actions Bot added the awaiting committer review Awaiting committer review label Jul 1, 2026

Copilot AI reviewed Jul 1, 2026

View reviewed changes

rok force-pushed the wasm_parallel_build_flag branch from 6d4a25b to 1d835a6 Compare July 1, 2026 13:15

gmake parsing issue

ef59f03

rok force-pushed the wasm_parallel_build_flag branch from 1d835a6 to ef59f03 Compare July 1, 2026 13:35

Copilot AI review requested due to automatic review settings July 1, 2026 13:35

Copilot started reviewing on behalf of rok July 1, 2026 13:37 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread r/inst/build_arrow_static.sh Outdated

rok mentioned this pull request Jul 1, 2026

GH-50295: [C++][R] #include <ranges> in vector_select_k.cc breaks macOS CRAN and wasm builds #50297

Merged

Potential fix for pull request finding

4f135a1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 1, 2026 13:59

Copilot started reviewing on behalf of rok July 1, 2026 14:00 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

rok changed the title ~~MINOR: [R] Use CMake -j${N_JOBS} instead of -j $N_JOBS~~ MINOR: [R] Unset MAKEFLAGS for nested libarrow CMake build Jul 1, 2026

kou reviewed Jul 2, 2026

View reviewed changes

github-actions Bot removed the awaiting committer review Awaiting committer review label Jul 2, 2026

rok force-pushed the wasm_parallel_build_flag branch from d53e514 to d7a63bc Compare July 2, 2026 18:05

Copilot started reviewing on behalf of rok July 2, 2026 18:06 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

rok force-pushed the wasm_parallel_build_flag branch from d7a63bc to 3e4ff27 Compare July 2, 2026 18:18

Fix -j flag earlier

f217bd2

Copilot AI review requested due to automatic review settings July 2, 2026 18:20

rok force-pushed the wasm_parallel_build_flag branch from 3e4ff27 to f217bd2 Compare July 2, 2026 18:20

Copilot started reviewing on behalf of rok July 2, 2026 18:21 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

another attempt

7999054

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 2, 2026

another attempt

a623cf5

Copilot AI review requested due to automatic review settings July 2, 2026 22:14

Copilot started reviewing on behalf of rok July 2, 2026 22:14 View session

github-actions Bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jul 2, 2026

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Uh oh!

Conversation

rok commented Jul 1, 2026

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

rok commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

rok commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

rok commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rok commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

rok commented Jul 1, 2026

Uh oh!

kou Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

rok Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

kou Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

rok Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

rok commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

rok commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

rok commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

rok commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

rok commented Jul 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview