GH-50298: [CI][R] Update ubuntu-clang CI job to use clang 22 to match CRAN#50299
Open
thisisnic wants to merge 1 commit into
Open
GH-50298: [CI][R] Update ubuntu-clang CI job to use clang 22 to match CRAN#50299thisisnic wants to merge 1 commit into
thisisnic wants to merge 1 commit into
Conversation
thisisnic
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
|
|
|
Member
Author
|
Once we're happy with this, we should file an issue on rhub |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the R “as-CRAN” CI workflow to better match CRAN’s current debian-clang toolchain by enabling an optional clang upgrade path for the rhub/ubuntu-clang image.
Changes:
- Adds a per-matrix flag (
r_update_clang) for theubuntu-clangjob to trigger a clang upgrade. - Wires
R_UPDATE_CLANGthrough the GitHub workflow → Docker Compose build args →linux-r.dockerfile→r_docker_configure.sh. - Adds an
apt.llvm.org-based installation step intended to install clang 22 inside the R image.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dev/tasks/r/github.linux.cran.yml | Adds matrix flag and env var to enable clang updates for ubuntu-clang. |
| compose.yaml | Passes R_UPDATE_CLANG into the r image build args. |
| ci/scripts/r_docker_configure.sh | Implements the clang 22 installation logic when R_UPDATE_CLANG=true. |
| ci/docker/linux-r.dockerfile | Introduces r_update_clang build arg and propagates it to R_UPDATE_CLANG. |
Comment on lines
+92
to
+99
| if [ "$R_UPDATE_CLANG" = true ]; then | ||
| apt-get update -y --allow-releaseinfo-change | ||
| apt-get install -y gnupg | ||
| curl -fsSL https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor -o /etc/apt/trusted.gpg.d/llvm.gpg | ||
| echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-22 main" > /etc/apt/sources.list.d/llvm22.list | ||
| apt-get update -y --allow-releaseinfo-change | ||
| apt-get install -y clang-22 lld-22 | ||
| fi |
Member
Author
|
@github-actions crossbow submit test-r-linux-as-cran |
|
Revision: f846f90 Submitted crossbow builds: ursacomputing/crossbow @ actions-9491b6cbd6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CI clang version outdated, false positive failures against CRAN
What changes are included in this PR?
Update clang manually
Are these changes tested?
Will run CI
Are there any user-facing changes?
No