fix(streaming): use event.index instead of at(-1) for content block lookup#1080
Open
yen0304 wants to merge 1 commit into
Open
fix(streaming): use event.index instead of at(-1) for content block lookup#1080yen0304 wants to merge 1 commit into
yen0304 wants to merge 1 commit into
Conversation
…ookup The event emission code in #addStreamEvent used .at(-1) to look up the current content block, while the accumulation code in #accumulateMessage correctly used event.index. This is inconsistent and would return the wrong content block if deltas ever arrived for a non-final block. The Python SDK already uses event.index in the equivalent code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#addStreamEventused.at(-1)to look up the current content block for event emission, while#accumulateMessagecorrectly usedevent.indexevent.indexin the equivalent code pathAffects both
MessageStream.tsandBetaMessageStream.ts(content_block_deltaandcontent_block_stophandlers).