Skip to content

refactor(navigation): extract Reviewer/New Study Screen as a destination - #21441

Merged
criticalAY merged 2 commits into
ankidroid:mainfrom
david-allison:multimodule-extraction-5
Aug 15, 2026
Merged

refactor(navigation): extract Reviewer/New Study Screen as a destination#21441
criticalAY merged 2 commits into
ankidroid:mainfrom
david-allison:multimodule-extraction-5

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Fable 5

Purpose / Description

Part of the :widgets extraction.

Fixes

Approach

Continue the pattern started in:

How Has This Been Tested?

⚠️ Untested

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • DeckPickerScreenshotTest: 1 change
All 1 changed screenshots

DeckPickerScreenshotTest

  • hierarchy_lines_collapsed_compare.png

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!! Thanks LGTM!

@criticalAY
criticalAY added this pull request to the merge queue Aug 15, 2026
@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Aug 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 15, 2026
@criticalAY
criticalAY force-pushed the multimodule-extraction-5 branch from f3904fd to 4d10e78 Compare August 15, 2026 21:57
@criticalAY
criticalAY enabled auto-merge August 15, 2026 21:57
@criticalAY

criticalAY commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

That's on me sorry about that Fixed

Adds a `ReviewDeckDestination` to `:anki-common`, with an explicit
NavigationType for the CLEAR_TOP task-stack behavior.

Part of 20737

Assisted-by: Claude Fable 5
Reviewer.getIntent remains for the 'review cards' app shortcut.

Part of 20737

Assisted-by: Claude Fable 5
@criticalAY
criticalAY force-pushed the multimodule-extraction-5 branch from 4d10e78 to ec93e71 Compare August 15, 2026 22:12
@criticalAY
criticalAY added this pull request to the merge queue Aug 15, 2026
Merged via the queue into ankidroid:main with commit abc547e Aug 15, 2026
21 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone Aug 15, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants