Skip to content

refactor: migrate StudyOptions to destination pattern - #21437

Merged
david-allison merged 3 commits into
ankidroid:mainfrom
david-allison:StudyOptionsActivity-navigate
Aug 15, 2026
Merged

refactor: migrate StudyOptions to destination pattern #21437
david-allison merged 3 commits into
ankidroid:mainfrom
david-allison:StudyOptionsActivity-navigate

Conversation

@david-allison

@david-allison david-allison commented Aug 9, 2026

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Fable 5

Purpose / Description

Mechanical refactoring - allows for a Destination to be referenced by a ViewModel, and by feature modules once we go multimodule.

Fixes

Approach

Continue the pattern started in:

How Has This Been Tested?

  • Untested

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
docs(navigation): fix typo
6254d6e
@david-allison
refactor: migrate StudyOptions to destination pattern
84cd8f6 
For our mutlimodule migration in future, and better ViewModel navigation now

Related to 20558
Part of 20737

Assisted-by: Claude Fable 5 - all
@david-allison
refactor: inline openStudyOptionsAndFinish
f274e8e 
Now it's only 2 lines, we can remove the method

The TODOs and comment were stale
@david-allison
david-allison force-pushed the StudyOptionsActivity-navigate branch from e62cbd9 to f274e8e Compare August 9, 2026 13:12
@github-actions

github-actions Bot commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • DeckPickerScreenshotTest: 1 change
All 1 changed screenshots

DeckPickerScreenshotTest

  • hierarchy_lines_collapsed_compare.png

@david-allison
david-allison added this pull request to the merge queue Aug 15, 2026
@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Aug 15, 2026
@criticalAY

criticalAY commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

That was fast 😆

Merged via the queue into ankidroid:main with commit fb0a979 Aug 15, 2026
21 of 22 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone Aug 15, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Aug 15, 2026
@david-allison
david-allison deleted the StudyOptionsActivity-navigate branch August 15, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@criticalAY criticalAY criticalAY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.25 release

Development

Successfully merging this pull request may close these issues.

2 participants

@david-allison @criticalAY