fix(@angular/ssr): replace all route parameters when resolving relative redirects#33516
Merged
alan-agius4 merged 1 commit intoJul 6, 2026
Conversation
…ve redirects When resolving a relative `redirectTo` property for a route with multiple path parameters (e.g. `:param1/:param2`), only the first parameter segment was being converted to `*` because a non-global regular expression was used. This commit updates `resolveRedirectTo` to use `URL_PARAMETER_GLOBAL_REGEXP` so that all parameter placeholders in the route path are properly replaced with `*`. Fixes angular#33504
alan-agius4
added
action: review
alan-agius4
force-pushed
the
fix-33504-relative-redirect-multi-param
branch
from
3c199f2 to
29297ec
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the route redirection resolution in Angular SSR to support multiple path parameters by replacing URL_PARAMETER_REGEXP with URL_PARAMETER_GLOBAL_REGEXP when resolving relative redirects. It also adds a corresponding unit test to verify nested redirects with multiple path parameters. There are no review comments, so I have no feedback to provide.
clydin
approved these changes
Jul 6, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resolving a relative
redirectToproperty for a route with multiple path parameters (e.g.:param1/:param2), only the first parameter segment was being converted to*because a non-global regular expression was used.This commit updates
resolveRedirectToto useURL_PARAMETER_GLOBAL_REGEXPso that all parameter placeholders in the route path are properly replaced with*.Fixes #33504