Skip to content

Fix issue where ForwardingAudioOutputProvider wasn't forwarding audio capabilities - #3343

Closed
nift4 wants to merge 1 commit into
androidx:mainfrom
nift4:faopcapfwd
Closed

nift4 wants to merge 1 commit into
androidx:mainfrom
nift4:faopcapfwd

Conversation

@nift4

@nift4 nift4 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@icbaker
icbaker requested a review from tonihei July 28, 2026 15:23
@icbaker icbaker assigned icbaker and tonihei and unassigned icbaker Jul 28, 2026
@tonihei

tonihei commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

This isn't as straight-forward as you make it look like I'm afraid. The AudioOutputProvider has methods to check the format support internally based on its knowledge of the output path. The AudioCapabilties class is tighly coupled to the default AudioTrack output path and can't be easily moved to the stable API surface. That's the reason it's only available on the AudioTrackAudioOutputProvider. In fact, the method was only added there as a slightly hacky workaround to retrieve the available spatialization channel masks to configure IAMF output in the codec, and it has no other purpose. Given that, we'd need to find a more generic solution for the IAMF config problem instead of simply publishing the AudioCapabilities via the interface.

@nift4

nift4 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the explaination, I see. So it's only a short term solution, that makes sense.

@nift4 nift4 closed this Aug 14, 2026
@nift4
nift4 deleted the faopcapfwd branch August 14, 2026 11:37
@nift4

nift4 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Are you interested in a PR taking a shot at a more generic API to query suggested spatialization, or is the problem it not being spec'd out yet?

@tonihei

tonihei commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

We haven't thought this through yet to see what the best design would be exactly to be honest. If you have a suggestion for something that fits nicely into the interface, feel free to suggest it for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants