Guard MetricFileNameComparator against filenames with fewer than 3 parts - #3633
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Guard MetricFileNameComparator against filenames with fewer than 3 parts#3633vasiliy-mikhailov wants to merge 1 commit into
vasiliy-mikhailov wants to merge 1 commit into
Conversation
MetricFileNameComparator.compare splits the metric file name on "." and reads index [2] (and [3] for pid-prefixed names) without checking the array length, so a name with fewer parts (e.g. "metrics.log") throws ArrayIndexOutOfBoundsException during sorting. Fall back to an empty string when the part is absent. Adds a test.
oss-sentinel-ai
approved these changes
Sep 3, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Summary
LGTM. Guards MetricFileNameComparator against metric file names with fewer dot-separated parts than expected, preventing ArrayIndexOutOfBoundsException; the added regression test covers the short-filename case. Trivial, well-scoped defensive fix.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetricWriter.MetricFileNameComparator.comparesplits the metric file name on"."and reads index[2](and[3]for pid-prefixed names) without checking the array length. A name with fewer parts (for example"metrics.log") therefore throwsArrayIndexOutOfBoundsExceptionduring sorting. This falls back to an empty string when the part is absent. Adds a test.AI assistance disclosure
This contribution was produced with the help of an AI pipeline. The pipeline processed a large amount of source code to surface suspected bugs, reproduced a subset of them with failing unit tests and generated candidate fixes, and prepared pull requests from the ones that held up. Each PR was then reviewed and verified by a human before being opened: the fix and test were checked by hand and the test was confirmed to fail before the change and pass after.