fixed docs/agents/ - #460
Closed
rajarshidattapy wants to merge 8 commits into
Closed
Conversation
…duce the bug: - session-manager.ts:24-33 — new exported toGotoWaitUntil() carrying the 'none' → 'commit' mapping and the explanatory comment that previously lived inline at the navigate site. - session-manager.ts:248 — newPage input widened with waitUntil?: 'load' | 'none'. - session-manager.ts:260 — the hardcoded 'load' replaced with toGotoWaitUntil(input.waitUntil). - actions.ts:161 — tabs/new now passes waitUntil: command.waitUntil through, which it was silently dropping. - actions.ts:113 — navigate switched to the same helper, so both paths share one implementation. I used a shared helper rather than copying the ternary into newPage. Duplicating it would have been a two-line diff, but a duplicated mapping in two files is precisely what let this bug survive the agentrhq#106 fix. Verification - npx vitest run --project unit src/browser/runtime/local-cloak/provider.test.ts — 27 passed. That includes a new test mirroring the existing navigate pair: tabs/new with waitUntil: 'none' now asserts goto receives 'commit'. The pre-existing test at line 318 still asserts the default is 'load', so both branches are covered. - npx tsc --noEmit reports one error, and it is not from this change: src/fetch/client.ts(2,23): Cannot find module 'impit'. impit@0.14.3 is in package.json dependencies but absent from node_modules here — a stale local install, not a code problem. Run npm install and it should clear; worth confirming on your side before you push, since I can't distinguish "not installed locally" from "genuinely broken on main" without it.
…wpage-wait-until
# Conflicts: # docs/cli-reference.mdx # skills/webcmd-browser/SKILL.md # src/browser/command-catalog.ts # src/cli.test.ts # src/cli.ts
Upstream's background-window default (agentrhq#328) adds a hidden anchor page per profile launch, so the first real tab in a fresh session now lands on pages[0], not pages[1] — matching the existing "creates, selects, and closes tabs by command op" test's convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.