fix(sdk): add timeout and reject path to waitForFillByDepositTx - #273
Open
devtechedge wants to merge 1 commit into
Open
fix(sdk): add timeout and reject path to waitForFillByDepositTx#273devtechedge wants to merge 1 commit into
devtechedge wants to merge 1 commit into
Conversation
Stop infinite polling by rejecting with WaitForFillTimeoutError after a configurable timeout (default 5 minutes). Fixes across-protocol#271
devtechedge
requested review from
amateima,
ashwinrava,
dohaki,
gsteenkamp89,
melisaguevara,
mrice32 and
nicholaspai
as code owners
September 9, 2026 21:13
|
@devtechedge is attempting to deploy a commit to the UMA Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForFillByDepositTxpreviously returned a Promise with only a resolve path. Polling continued forever on both "not yet filled" and unexpected errors, which could hang callers and keep the event loop alive indefinitely.This change adds a reject path and a configurable
timeout(default 5 minutes). When the deadline is reached, the Promise rejects withWaitForFillTimeoutErrorfor the usual pending-fill case (NoFillLogError), or with the underlying error for other failures.Changes
timeoutparam towaitForFillByDepositTx(defaultDEFAULT_WAIT_FOR_FILL_TIMEOUT_MS= 300000)WaitForFillTimeoutErrorwhen polling exceeds the deadlineTest plan
vitest run test/unit/actions/waitForFillByDepositTx.test.ts(timeout rejection + default timeout constant)timeoutexplicitlyFixes #271