fix(sdk): return undefined from parseFillLogs on empty logs - #272
Open
devtechedge wants to merge 1 commit into
Open
fix(sdk): return undefined from parseFillLogs on empty logs#272devtechedge wants to merge 1 commit into
devtechedge wants to merge 1 commit into
Conversation
Guard against reading logs[0] when the caller passes an empty array so parseFillLogs returns undefined instead of throwing a TypeError. Fixes across-protocol#268
devtechedge
requested review from
amateima,
ashwinrava,
dohaki,
gsteenkamp89,
melisaguevara,
mrice32 and
nicholaspai
as code owners
September 9, 2026 21:06
|
@devtechedge is attempting to deploy a commit to the UMA Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseFillLogscurrently buildsblockDatafromlogs[0]before checking whether any fill event is present. When callers pass an emptylogsarray (a valid "no fill found" case), that access throws aTypeErrorinstead of returningundefined.This change adds an early return for
logs.length === 0, matching the existing no-match behavior for non-empty logs that do not contain a fill event.Changes
parseFillLogsso an emptylogsarray returnsundefinedTest plan
vitest run test/unit/actions/parseFillLogs.test.ts(empty array and non-fill logs both returnundefined)undefinedcontinue to work as expectedFixes #268