Skip to content

IPv6 support for multisite wp_registration_log #9911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd32 wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

IPv6 support for multisite wp_registration_log #9911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d02ac35
Increase length of IP field to account for IPv6
dd32 Sep 16, 2025
1a3edad
Update IP address sanitization to accept IPv6
dd32 Sep 16, 2025
f9ec707
Update the schema update to account for the changed table.
dd32 Sep 16, 2025
4d24526
Strip non-ip-characters
dd32 Feb 19, 2026
feed712
Merge branch 'trunk' into patch/ipv6-registration_log
t-hamano Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-admin/includes/schema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ function wp_get_db_schema( $scope = 'all', $blog_id = null ) {
CREATE TABLE $wpdb->registration_log (
ID bigint(20) unsigned NOT NULL auto_increment,
email varchar(255) NOT NULL default '',
IP varchar(30) NOT NULL default '',
IP varchar(39) NOT NULL default '',
blog_id bigint(20) unsigned NOT NULL default '0',
date_registered datetime NOT NULL default '0000-00-00 00:00:00',
PRIMARY KEY (ID),
Expand Down
5 changes: 4 additions & 1 deletion src/wp-admin/includes/upgrade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3743,7 +3743,7 @@ function pre_schema_upgrade() {
}

// Multisite schema upgrades.
if ( $wp_current_db_version < 60497 && is_multisite() && wp_should_upgrade_global_tables() ) {
if ( $wp_current_db_version < 60498 && is_multisite() && wp_should_upgrade_global_tables() ) { // TODO: Update with commit.

// Upgrade versions prior to 3.7.
if ( $wp_current_db_version < 25179 ) {
Expand Down Expand Up @@ -3771,6 +3771,9 @@ function pre_schema_upgrade() {
$wpdb->query( "ALTER TABLE $wpdb->sitemeta MODIFY site_id bigint(20) unsigned NOT NULL default 0" );
$wpdb->query( "ALTER TABLE $wpdb->signups MODIFY signup_id bigint(20) unsigned NOT NULL auto_increment" );
}
if ( $wp_current_db_version < 60498 ) { // TODO: Update with commit.
$wpdb->query( "ALTER TABLE $wpdb->registration_log MODIFY IP varchar(39) NOT NULL default ''" );
}
}

// Upgrade versions prior to 4.2.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-includes/ms-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2122,7 +2122,7 @@ function wpmu_log_new_registrations( $blog_id, $user_id ) {
$wpdb->registration_log,
array(
'email' => $user->user_email,
'IP' => preg_replace( '/[^0-9., ]/', '', wp_unslash( $_SERVER['REMOTE_ADDR'] ) ),
'IP' => preg_replace( '/[^a-f0-9:.]/', '', wp_unslash( $_SERVER['REMOTE_ADDR'] ) ),
'blog_id' => $blog_id,
'date_registered' => current_time( 'mysql' ),
)
Expand Down
Loading