#64893 Remove tag triggers for all workflows - #12717
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
This PR removes push.tags triggers from all GitHub Actions workflows to prevent redundant CI runs when release tags are pushed in the SVN→Git mirror (where tag commits typically have identical trees to their already-tested parent commits), reducing queue pressure during releases.
Changes:
- Removed tag-based triggers from CI workflows so they no longer run on
git push --tags. - Kept existing branch-based, PR-based, and manual (
workflow_dispatch) triggers intact for coverage continuity.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/upgrade-develop-testing.yml | Removes tag triggers so upgrade-develop tests only run on branches/PRs/manual dispatch. |
| .github/workflows/test-build-processes.yml | Removes tag triggers to avoid redundant build-process testing on tag pushes. |
| .github/workflows/phpunit-tests.yml | Removes tag triggers so PHPUnit runs are not duplicated for release tags. |
| .github/workflows/phpstan-static-analysis.yml | Removes tag triggers to prevent PHPStan runs on tag pushes. |
| .github/workflows/php-compatibility.yml | Removes tag triggers to avoid PHP compatibility scans on tag pushes. |
| .github/workflows/performance.yml | Removes tag triggers to avoid performance runs on tag pushes. |
| .github/workflows/javascript-type-checking.yml | Removes tag triggers to prevent JS type checking on tag pushes. |
| .github/workflows/javascript-tests.yml | Removes tag triggers to prevent JS test runs on tag pushes. |
| .github/workflows/end-to-end-tests.yml | Removes tag triggers to avoid e2e runs on tag pushes. |
| .github/workflows/coding-standards.yml | Removes tag triggers to avoid duplicate lint/standards checks on tag pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
lancewillett
left a comment
lancewillett
left a comment
There was a problem hiding this comment.
No blockers that I can see. Premise is logical.
Tag commits in the svn→git mirror have a tree identical to their already tested parent, so re-running the full suite on the tag is pure redundancy.
Tags in the `wordpress-develop` repo originate from the corresponding svn tag. This means the target commit for the tag must already exist on `wordpress-develop` and therefore its full workflow has already run, usually just minutes prior to the tag being pushed. This change eliminates this unnecessary duplicate workflow run and reduces bottlenecks experienced during releases. Developed in #12717 Props lancewillett, johnbillion See #64893 git-svn-id: https://develop.svn.wordpress.org/trunk@62855 602fd350-edb4-49c9-b593-d223f7449a82
Tags in the `wordpress-develop` repo originate from the corresponding svn tag. This means the target commit for the tag must already exist on `wordpress-develop` and therefore its full workflow has already run, usually just minutes prior to the tag being pushed. This change eliminates this unnecessary duplicate workflow run and reduces bottlenecks experienced during releases. Developed in WordPress/wordpress-develop#12717 Props lancewillett, johnbillion See #64893 Built from https://develop.svn.wordpress.org/trunk@62855 git-svn-id: http://core.svn.wordpress.org/trunk@62135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In the svn to git mirror, tagging produces a commit whose tree is identical to its parent which was usually just pushed and tested minutes earlier.
Examples from the 7.0.2 release:
855551c66825fd66825fd22cfe235d6c77b5d6c77bc4ee97a94857d494857d4During the release of the above versions on July 17th, the three tags spawned 795 jobs between 17:58 and 17:59 UTC. The queue peaked at over 1,200 jobs around this time and held up the installation and upgrade tests that are manually run once the packages are built.
Completely removing workflow runs for tag pushes doesn't lose us any coverage and it significantly reduces the bottleneck of workflow runs that we get at release time.
Trac ticket: Core-64893
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Initial investigation into tag-triggered workflows was performed by Claude Code, all verified manually